[MIRROR] Fixes a bug with hash grinding #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hash grinding
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4716
About The Pull Request
So it came to my attention that hash creation does not work currently. You are supposed to be able to grind dried cannabis leaves using a mortar and pestle or reagent grinder but it fails to do so due to a bug.
The original code was trying to do some hackish stuff that no longer works with all the subsequent changes to grinding post-foodening. This PR just restores the ability to make this.
Some notes: You can still make hash from grinding dried mutated strains but it gets to be a bit silly with all the extra reagents that you get in your beaker or mortar. That cannot really be helped short of changing the way hash gets created but I do not really see it as an issue so much as just how produce grinding works. Another note: rainbow cannabis contains no thc so thus does not yield any hash when ground.
How This Contributes To The Nova Sector Roleplay Experience
Proof of Testing
Screenshots/Videos
Foxboi druglab...
Changelog
🆑 vinylspiders
fix: hash can now be created again by grinding dried cannabis leaves in a grinder or with a mortar and pestle
/:cl: